Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated kustomize constructs with their new equivalent #1937

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Replace deprecated kustomize constructs with their new equivalent #1937

merged 2 commits into from
Jun 1, 2024
+37 −30

Conversation

ddelnano
Copy link
Member

@ddelnano ddelnano commented May 31, 2024 •
edited
Loading

Summary: Replace deprecated kustomize constructs with their new equivalent

Relevant Issues: N/A

Type of change: /kind cleanup

Test Plan: Modified these files with kustomize edit fix and verified the following:

  • yaml is equivalent before and after
# Create 'new' file from branch
(ddelnano/replace-deprecated-kustomize-patches-config) $ for env in dev prod public staging; do kustomize build k8s/cloud_deps/$env/elastic > k8s/cloud_deps/$env/elastic/new; done

# Create 'old' file from main
(main) $ for env in dev prod public staging; do kustomize build k8s/cloud_deps/$env/elastic > k8s/cloud_deps/$env/elastic/old; done
# Warning: 'patchesJson6902' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesJson6902' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesJson6902' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesJson6902' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

# Verify shas are the same
$ for env in dev prod public staging; do sha256sum k8s/cloud_deps/$env/elastic/{old,new}; done
2c7459bcc8de323dd30ced4459257d130eef9b56f417b66317e64596d047b8ea  k8s/cloud_deps/dev/elastic/old
2c7459bcc8de323dd30ced4459257d130eef9b56f417b66317e64596d047b8ea  k8s/cloud_deps/dev/elastic/new
bfe20c85b5b90ef029f536f025dc45ab5b40f71def02af19c5d5d54950ae8a01  k8s/cloud_deps/prod/elastic/old
bfe20c85b5b90ef029f536f025dc45ab5b40f71def02af19c5d5d54950ae8a01  k8s/cloud_deps/prod/elastic/new
827ceddfb37cd86b06a5b41efbc2a11ffde7848332fdfdccbc436c50cf9672ac  k8s/cloud_deps/public/elastic/old
827ceddfb37cd86b06a5b41efbc2a11ffde7848332fdfdccbc436c50cf9672ac  k8s/cloud_deps/public/elastic/new
ac25554df51e00853e419419ecdb4b3a0945c14bd4e6750303537ac7d80757e4  k8s/cloud_deps/staging/elastic/old
ac25554df51e00853e419419ecdb4b3a0945c14bd4e6750303537ac7d80757e4  k8s/cloud_deps/staging/elastic/new

@ddelnano ddelnano requested a review from a team as a code owner May 31, 2024 22:49
@ddelnano ddelnano changed the title Replace deprecated skaffold constructs with their new equivalent Replace deprecated kustomize constructs with their new equivalent May 31, 2024
@ddelnano ddelnano force-pushed the ddelnano/replace-deprecated-kustomize-patches-config branch from 72d14c0 to 9169ce2 Compare June 1, 2024 15:35
@ddelnano ddelnano merged commit bbb6ea4 into pixie-io:main Jun 1, 2024
18 checks passed
@ddelnano ddelnano deleted the ddelnano/replace-deprecated-kustomize-patches-config branch June 1, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vihangm vihangm vihangm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddelnano @vihangm